echauchot commented on a change in pull request #14558:
URL: https://github.com/apache/flink/pull/14558#discussion_r557317706
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterJobClient.java
##########
@@ -106,7 +108,25 @@ public JobID getJobID() {
@Override
public CompletableFuture<Map<String, Object>> getAccumulators() {
- return
getJobExecutionResult().thenApply(JobExecutionResult::getAllAccumulatorResults);
+ //TODO: this is not the only case when we need to get the accumulators
from JobExecutionResult.
+ // It is needed also for UnalignedCheckpointCompatibilityITCase
savepoints tests to pass.
+ // What is the complete condition ?
+ if (!miniCluster.isRunning()) {
Review comment:
agree `miniCluster.isRunning()` is more a side effect of
`PerJobMiniClusterFactoryTest.testJobExecution` stopping the minicluster when
the job is done. `jobResultFuture.isDone()` is definitely a better condition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
