rkhachatryan commented on a change in pull request #14635:
URL: https://github.com/apache/flink/pull/14635#discussion_r557464399
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/FailedCheckpointStats.java
##########
@@ -87,15 +72,20 @@
@Nullable SubtaskStateStats latestAcknowledgedSubtask,
@Nullable Throwable cause) {
- super(checkpointId, triggerTimestamp, props, totalSubtaskCount,
taskStats);
+ super(
+ checkpointId,
+ triggerTimestamp,
+ props,
+ totalSubtaskCount,
+ numAcknowledgedSubtasks,
+ taskStats,
+ PendingCheckpointStatsCallback.noOp(),
Review comment:
First, `PendingCheckpointStats` is created. It has "normal" callbacks
and subtasks reports update it as usual.
Upon failure it is converted to a `FailedCheckpointStats` using one of these
"normal" callbacks.
This new object won't be converted so it has `noOp` callbacks. It still can
be updated from subtasks.
I tried to refactor this code to have just one `CheckpointStats` class
without conversions and callbacks.
But the change was to big compared to the functionality added so I dropped
it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
