rmetzger commented on a change in pull request #14499:
URL: https://github.com/apache/flink/pull/14499#discussion_r557501790
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/ClusterOptions.java
##########
@@ -88,21 +93,28 @@
.build());
@Documentation.Section(Documentation.Sections.EXPERT_CLUSTER)
- public static final ConfigOption<Boolean> HALT_ON_FATAL_ERROR =
- key("cluster.processes.halt-on-fatal-error")
+ public static final ConfigOption<Boolean> HALT_ON_SYSTEM_EXIT =
+ key("cluster.processes.halt-on-system-exit")
Review comment:
The reason why I proposed to change the configuration key away from
"halt-on-fatal-error" is that the name is quite misleading. It sounds like
fatal errors are causing a System.getRuntime().halt(), however, it means "all
system exit calls are replaced by halt()".
The behavior in case of a fatal error is described in
FatalExitExceptionHandler (I guess).
You are right that changing a configuration variable is not advised. It
seems that there was some discussion on the configuration parameter, when it
was introduced (last comments:
https://issues.apache.org/jira/browse/FLINK-16510). Let's go with @hwanju's
proposal and keep the configuration name as-is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
