Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1822#discussion_r56904841
  
    --- Diff: 
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/ReduceProperties.java
 ---
    @@ -61,6 +65,9 @@ public SingleInputPlanNode instantiate(Channel in, 
SingleInputNode node) {
                if (in.getShipStrategy() == ShipStrategyType.FORWARD ||
                                (node.getBroadcastConnections() != null && 
!node.getBroadcastConnections().isEmpty()))
                {
    +                   if(in.getSource().getOptimizerNode() instanceof 
PartitionNode) {
    +                           LOG.warn("Consider adding an explicit 
CombinerFunction with groupCombine in front of the partition operator");
    --- End diff --
    
    Can you extend the error message as follows?
    
    > Cannot automatically inject combiner for ReduceFunction. Please add an 
explicit combiner with combineGroup() in front of the partition operator. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to