Myasuka opened a new pull request #14662:
URL: https://github.com/apache/flink/pull/14662


   ## What is the purpose of the change
   
   Compared with https://github.com/apache/flink/pull/14656, this PR add 
another commit to refactor interfaces to decline checkpoint with 
`CheckpointException` instead of previous `Throwable`.
   
   Currently, no mater how many times of async checkpoint failure, job would 
not trigger failover. This PR ensure the mechanism of failing the job by 
default when async phase of checkpoint failed, which was broken in FLINK-12364.
   
   ## Brief change log
   
     - Let `CHECKPOINT_ASYNC_EXCEPTION` could also be treated to fail the job.
     - Ensure decline checkpoint with specific `CheckpointException` instead of 
previous `throwable`.
     - If task is not running, never decline the checkpoint on task side to 
avoid unexpected failover again.
     - refactor interfaces to decline checkpoint with `CheckpointException` 
instead of previous `Throwable`.
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - Added 
`CheckpointFailureManagerITCase#testAsyncCheckpointFailureTriggerJobFailed` to 
ensure job would failed once async checkpoint failed.
     
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **yes**
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to