[
https://issues.apache.org/jira/browse/FLINK-20914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267273#comment-17267273
]
Robert Metzger commented on FLINK-20914:
----------------------------------------
Merged to master in
https://github.com/apache/flink/commit/7176881cc76b8361151b8c2a1cf946f45c7bcc7f.
I saw that you opened two pull with small improvements to the configuration
descriptions. I'm very happy that you are contributing to the Flink community,
and I want to encourage you to improve the Flink project by working on open
issues of Flink. However, I'm not sure if searching for minor issues in the
configuration descriptions is a good use of your and our time. It could very
well be that you won't always find a committer who has the time to review and
merge such changes.
The Flink community is pretty constrained in "reviewing resources", and we will
always select pull requests that fix a bug, or add a feature users need.
I hope you understand what I mean.
> Format the description of 'security.ssl.internal.session-cache-size' option
> ---------------------------------------------------------------------------
>
> Key: FLINK-20914
> URL: https://issues.apache.org/jira/browse/FLINK-20914
> Project: Flink
> Issue Type: Improvement
> Components: API / Core
> Affects Versions: 1.12.0
> Reporter: Ruguo Yu
> Assignee: Ruguo Yu
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.13.0
>
>
> The description of ConfigOption 'security.ssl.internal.session-cache-size'
> has a URL link, as follows:
> {code:java}
> public static final ConfigOption<Integer> SSL_INTERNAL_SESSION_CACHE_SIZE =
> key("security.ssl.internal.session-cache-size")
> .intType()
> .defaultValue(-1)
> .withDescription(
> "The size of the cache used for storing SSL session
> objects. "
> + "According to
> https://github.com/netty/netty/issues/832, you should always set "
> + "this to an appropriate number to not run
> into a bug with stalling IO threads "
> + "during garbage collection. (-1 = use
> system default).")
> .withDeprecatedKeys("security.ssl.session-cache-size");
> {code}
> so the most reasonable way is to use *Text Description* with *Link,* as
> follows:
> {code:java}
> public static final ConfigOption<Integer> SSL_INTERNAL_SESSION_CACHE_SIZE =
> key("security.ssl.internal.session-cache-size")
> .intType()
> .defaultValue(-1)
> .withDescription(
> Description.builder()
> .text(
> "The size of the cache used for
> storing SSL session objects. "
> + "According to %s, you
> should always set "
> + "this to an appropriate
> number to not run into a bug with stalling IO threads "
> + "during garbage collection.
> (-1 = use system default).",
> link(
>
> "https://github.com/netty/netty/issues/832";,
> "here"))
> .build())
> .withDeprecatedKeys("security.ssl.session-cache-size");
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
