tillrohrmann commented on a change in pull request #14692:
URL: https://github.com/apache/flink/pull/14692#discussion_r560082524
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterDescriptor.java
##########
@@ -125,6 +121,16 @@ public String getClusterDescription() {
};
}
+ private String getWebMonitorAddress(Configuration configuration) throws
Exception {
+ HighAvailabilityServicesUtils.AddressResolution resolution =
+
HighAvailabilityServicesUtils.AddressResolution.TRY_ADDRESS_RESOLUTION;
+ if
(configuration.get(KubernetesConfigOptions.REST_SERVICE_EXPOSED_TYPE)
+ == KubernetesConfigOptions.ServiceExposedType.ClusterIP) {
+ resolution =
HighAvailabilityServicesUtils.AddressResolution.NO_ADDRESS_RESOLUTION;
+ }
+ return
HighAvailabilityServicesUtils.getWebMonitorAddress(configuration, resolution);
+ }
Review comment:
In the K8s case, from where exactly do we retrieve the address of the
service? If I understood you correctly, then `RestOptions.ADDRESS` contains
some address which is not resolvable from the outside. Hence, I am wondering
why we should try to construct the web monitor address from this configuration
at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
