zentol commented on a change in pull request #59:
URL: https://github.com/apache/flink-docker/pull/59#discussion_r561774922
##########
File path: docker-entrypoint.sh
##########
@@ -112,41 +111,26 @@ if [ "$1" = "help" ]; then
elif [ "$1" = "jobmanager" ]; then
args=("${args[@]:1}")
- prepare_job_manager_start
+ echo "Starting Job Manager"
exec $(drop_privs_cmd) "$FLINK_HOME/bin/jobmanager.sh" start-foreground
"${args[@]}"
elif [ "$1" = ${COMMAND_STANDALONE} ]; then
args=("${args[@]:1}")
- prepare_job_manager_start
+ echo "Starting Job Manager"
exec $(drop_privs_cmd) "$FLINK_HOME/bin/standalone-job.sh"
start-foreground "${args[@]}"
elif [ "$1" = ${COMMAND_HISTORY_SERVER} ]; then
args=("${args[@]:1}")
echo "Starting History Server"
- if [ -n "${FLINK_PROPERTIES}" ]; then
- echo "${FLINK_PROPERTIES}" >> "${CONF_FILE}"
- fi
- envsubst < "${CONF_FILE}" > "${CONF_FILE}.tmp" && mv "${CONF_FILE}.tmp"
"${CONF_FILE}"
Review comment:
I think you're being tricked by the diff; it is at the end of
prepare_configuration.
##########
File path: docker-entrypoint.sh
##########
@@ -112,41 +111,26 @@ if [ "$1" = "help" ]; then
elif [ "$1" = "jobmanager" ]; then
args=("${args[@]:1}")
- prepare_job_manager_start
+ echo "Starting Job Manager"
exec $(drop_privs_cmd) "$FLINK_HOME/bin/jobmanager.sh" start-foreground
"${args[@]}"
elif [ "$1" = ${COMMAND_STANDALONE} ]; then
args=("${args[@]:1}")
- prepare_job_manager_start
+ echo "Starting Job Manager"
exec $(drop_privs_cmd) "$FLINK_HOME/bin/standalone-job.sh"
start-foreground "${args[@]}"
elif [ "$1" = ${COMMAND_HISTORY_SERVER} ]; then
args=("${args[@]:1}")
echo "Starting History Server"
- if [ -n "${FLINK_PROPERTIES}" ]; then
- echo "${FLINK_PROPERTIES}" >> "${CONF_FILE}"
- fi
- envsubst < "${CONF_FILE}" > "${CONF_FILE}.tmp" && mv "${CONF_FILE}.tmp"
"${CONF_FILE}"
Review comment:
I think you're being tricked by the diff; it is at the end of
prepare_configuration. ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
