Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1741#discussion_r57004770
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java ---
    @@ -60,8 +63,8 @@
         * See documentation
         */
        public static int calculateHeapSize(int memory, 
org.apache.flink.configuration.Configuration conf) {
    -           float memoryCutoffRatio = 
conf.getFloat(ConfigConstants.YARN_HEAP_CUTOFF_RATIO, 
ConfigConstants.DEFAULT_YARN_HEAP_CUTOFF_RATIO);
    -           int minCutoff = 
conf.getInteger(ConfigConstants.YARN_HEAP_CUTOFF_MIN, 
ConfigConstants.DEFAULT_YARN_MIN_HEAP_CUTOFF);
    +           float memoryCutoffRatio = 
conf.getFloat(ConfigConstants.YARN_HEAP_CUTOFF_RATIO, 0.25f);
    +           int minCutoff = 
conf.getInteger(ConfigConstants.YARN_HEAP_CUTOFF_MIN, 600);
    --- End diff --
    
    Why not using the default values defined in the `ConfigConstants`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to