[
https://issues.apache.org/jira/browse/FLINK-21036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270262#comment-17270262
]
Till Rohrmann commented on FLINK-21036:
---------------------------------------
This is a bit off-topic but I have to admit that I don't really like
{{FLINK_PROPERTIES}}. I think we should get rid of it as soon as possible.
Maybe after we can configure Flink processes using environment variables. Isn't
it possible to specify dynamic properties when starting the Docker image? Then
one could pass {{-Dtaskmanager.numberOfTaskSlots=2}}, for example.
> Consider removing automatic configuration fo number of slots from docker
> ------------------------------------------------------------------------
>
> Key: FLINK-21036
> URL: https://issues.apache.org/jira/browse/FLINK-21036
> Project: Flink
> Issue Type: Improvement
> Components: Deployment / Scripts
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.13.0
>
>
> The {{docker-entrypoint.sh}} supports setting the number of task slots via
> the {{TASK_MANAGER_NUMBER_OF_TASK_SLOTS}} environment variable, which
> defaults to the number of cpu cores via {{$(grep -c ^processor
> /proc/cpuinfo)}}.
> The environment variable itself is redundant nowadays since we introduced
> {{FLINK_PROPERTIES}}, and is no longer documented.
> Defaulting to the number of CPU cores can be considered convenience, but it
> seems odd to have this specific to docker while the distribution defaults to
> {{1}}.
> The bigger issue in my mind though is that this creates a configuration
> mismatch between the Job- and TaskManager processes; the ResourceManager
> specifically needs to know how many slots a worker has to make decisions
> about redundancy and allocating resources.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
