sjwiesman commented on a change in pull request #13797:
URL: https://github.com/apache/flink/pull/13797#discussion_r562848702
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java
##########
@@ -468,12 +474,12 @@ private File getNextStoragePath() {
@Override
public CompletedCheckpointStorageLocation resolveCheckpoint(String
pointer) throws IOException {
- return checkpointStreamBackend.resolveCheckpoint(pointer);
+ return ((CheckpointStorage)
checkpointStreamBackend).resolveCheckpoint(pointer);
Review comment:
I would prefer not to, there are then a number of places where I would
need to cast it back to StateBackend, so there will be casts. Or I maintain the
reference in two variables and that seems more error-prone. RocksDBStateBackend
is deprecated in the follow-up PR anyway so I don't think this is that
problematic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
