Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1820#issuecomment-199877286
I think we should try to share more code between the DataSet and DataStream
translation. Otherwise it looks good.
We should also rework the tests and extract tests that check the Table API
parts that are common for DataSet and DataStream. I wouldn't do that in this PR
though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
