pnowojski commented on a change in pull request #14635:
URL: https://github.com/apache/flink/pull/14635#discussion_r563513306
##########
File path:
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/subtask/job-checkpoints-subtask.component.html
##########
@@ -99,7 +99,7 @@
<td>{{ subTask['index'] }}</td>
<ng-container *ngIf="subTask['status'] == 'completed'">
<td >{{ subTask['ack_timestamp'] | date:'yyyy-MM-dd HH:mm:ss' }}</td>
- <td>{{ subTask['end_to_end_duration'] | humanizeDuration}}</td>
+ <td>{{ subTask['end_to_end_duration'] | humanizeDuration}}<span
*ngIf="subTask['aborted']">(aborted)</span></td>
Review comment:
add space in front of `(aborted)`?
##########
File path: docs/ops/monitoring/checkpoint_monitoring.md
##########
@@ -61,7 +61,7 @@ Note that for failed checkpoints, metrics are updated on a
best efforts basis an
- **ID**: The ID of the triggered checkpoint. The IDs are incremented for each
checkpoint, starting at 1.
- **Status**: The current status of the checkpoint, which is either *In
Progress* (<i aria-hidden="true" class="fa fa-circle-o-notch fa-spin fa-fw"/>),
*Completed* (<i aria-hidden="true" class="fa fa-check"/>), or *Failed* (<i
aria-hidden="true" class="fa fa-remove"/>). If the triggered checkpoint is a
savepoint, you will see a <i aria-hidden="true" class="fa fa-floppy-o"/> symbol.
- **Trigger Time**: The time when the checkpoint was triggered at the
JobManager.
-- **Latest Acknowledgement**: The time when the latest acknowledgement for any
subtask was received at the JobManager (or n/a if no acknowledgement received
yet). For a failed checkpoint, this is the time from trigger timestamp to
failure.
+- **Latest Acknowledgement**: The time when the latest acknowledgement for any
subtask was received at the JobManager (or n/a if no acknowledgement received
yet).
Review comment:
Update the `.zh.md` version as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
