[GitHub] [flink] xiaoHoly commented on a change in pull request #14531: [FLINK-20777][Connector][Kafka] Property "partition.discovery.interval.ms" shoule be enabled by default for unbounded mode, and disable for bounded mode

Mon, 25 Jan 2021 19:58:34 -0800 


xiaoHoly commented on a change in pull request #14531:
URL: https://github.com/apache/flink/pull/14531#discussion_r563447765



##########
File path: 
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java
##########
@@ -396,6 +396,11 @@
                 props);
     }
 
+    /** setParitionDiscoverySetting . */

Review comment:
       @becketqin  Thanks  for comment,ACKļ¼VisibleForTesting is better ! i will 
update it 

##########
File path: 
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java
##########
@@ -396,6 +396,11 @@
                 props);
     }
 
+    /** setParitionDiscoverySetting . */

Review comment:
       @becketqin, please take a look this updates,thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to