Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1827#issuecomment-200025666
Thanks for the PR! Looks good overall.
I think we can save a few LOCs by refactoring common parts a bit. Also I
spotted more opportunities to use Scala's String building feature (`s""`) which
is nicer than String concatenation, IMO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
