aljoscha commented on a change in pull request #14765:
URL: https://github.com/apache/flink/pull/14765#discussion_r565454972
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/iterator/RocksSingleStateIterator.java
##########
@@ -23,11 +23,13 @@
import javax.annotation.Nonnull;
+import java.io.Closeable;
+
/**
* Wraps a RocksDB iterator to cache it's current key and assigns an id for
the key/value state to
* the iterator. Used by {@link RocksStatesPerKeyGroupMergeIterator}.
*/
-class RocksSingleStateIterator implements AutoCloseable {
+class RocksSingleStateIterator implements Closeable {
Review comment:
I made it `Closeable` because the `RocksStatesPerKeyGroupMergeIterator`
now uses a `CloseableRegistry` which requires things to be `Closeable`.
Alternatively, I could change `CloseableRegistry` to take `AutoCloseables`
but I felt that would be the bigger change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
