zentol opened a new pull request #14806: URL: https://github.com/apache/flink/pull/14806
The parameter for triggering savepoints (the `targetDirectory` and whether the job should be canceled/drained) are supposed to be optional, but this is not working as expected because we fail on missing primitives. I assume the expectation was that the `defaultValue` attribute of the `JsonProperty` annotation would handle it, but as it turns out this is just for documentation purposes. To fix it we no longer use primitives. We could also disable `DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES`, but ain't no one got time to ensure this doesn't break anything for other bodies. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
