wuchong commented on a change in pull request #14802:
URL: https://github.com/apache/flink/pull/14802#discussion_r567784993
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java
##########
@@ -697,6 +703,9 @@ private void dropTemporaryTableInternal(
CatalogBaseTable catalogBaseTable =
temporaryTables.get(objectIdentifier);
if (filter.test(catalogBaseTable)) {
temporaryTables.remove(objectIdentifier);
+ Optional<TemporaryOperationListener> listener =
+ getTemporaryOperationListener(objectIdentifier);
+ listener.ifPresent(l ->
l.onDropTemporaryTable(objectIdentifier.toObjectPath()));
Review comment:
I also agree `onDropTemporaryTable succeeds but removing table fails` is
meaningless. What I want to avoid is `removing table succeeds but
onDropTemporaryTable fails`, that means users may not have chance to remove the
temporary data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
