twalthr commented on a change in pull request #14801:
URL: https://github.com/apache/flink/pull/14801#discussion_r567901514
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/catalog/CatalogTableITCase.scala
##########
@@ -1121,6 +1122,27 @@ class CatalogTableITCase(isStreamingMode: Boolean)
extends AbstractTestBase {
expectedProperty.put("k2", "b")
assertEquals(expectedProperty, database.getProperties)
}
+
+ @Test
+ def testFloatIn(): Unit = {
+ val source = tableEnv.fromValues(
+ DataTypes.ROW(
+ DataTypes.FIELD("f0", DataTypes.FLOAT()),
+ DataTypes.FIELD("f1", DataTypes.FLOAT()),
+ DataTypes.FIELD("f2", DataTypes.FLOAT())),
+ toRow(1.0f, 11.0f, 12.0f),
+ toRow(2.0f, 21.0f, 22.0f),
+ toRow(3.0f, 31.0f, 32.0f),
+ toRow(4.0f, 41.0f, 42.0f),
+ toRow(5.0f, 51.0f, 52.0f)
+ )
+ tableEnv.createTemporaryView("myTable", source)
+ val query =
+ """
+ |select * from myTable where f0 in (1.0, 2.0, 3.0)
+ |""".stripMargin
+ tableEnv.executeSql(query).collect()
Review comment:
Please verify the result.
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/catalog/CatalogTableITCase.scala
##########
@@ -1121,6 +1122,27 @@ class CatalogTableITCase(isStreamingMode: Boolean)
extends AbstractTestBase {
expectedProperty.put("k2", "b")
assertEquals(expectedProperty, database.getProperties)
Review comment:
`CatalogTableITCase` is mostly for testing the interaction with the
catalog. Can we move this test to `CalcITCase`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
