gaoyunhaii commented on a change in pull request #14740:
URL: https://github.com/apache/flink/pull/14740#discussion_r568377165
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -223,16 +214,25 @@
private boolean isTriggering = false;
private final CheckpointRequestDecider requestDecider;
+
+ private final CheckpointBriefCalculator checkpointBriefCalculator;
+
+ private final ExecutionAttemptMappingProvider attemptMappingProvider;
+
private final LinkedHashMap<ExecutionAttemptID, ExecutionVertex>
cachedTasksById;
+ /**
+ * Temporary flag to allow checkpoints after tasks finished. This is
disabled for regular jobs
+ * to keep the current behavior but we want to allow it in tests. This
should be removed once
+ * all parts of the stack support checkpoints after some tasks finished.
+ */
+ private boolean allowCheckpointsAfterTasksFinished;
Review comment:
It is currently used in `calculateCheckpointBrief()` to disable
checkpoints after tasks finished. Previously I'm thinking to enable this flag
in tests, but now I realized it would makes more sense to keep the tests and
the normal process consistent. I think it reveals some tests are missed for our
scenarios and I'll complement the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
