[ 
https://issues.apache.org/jira/browse/FLINK-21221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277033#comment-17277033
 ] 

Yangze Guo commented on FLINK-21221:
------------------------------------

The {{org.apache.flink.runtime.jobmaster.slotpool.ResourceCounter}} looks 
powerful. So, I think we can replace the 
{{org.apache.flink.runtime.slots.ResourceCounter}}. Moreover, I think this 
class should be move to  another path, such as "org.apache.flink.runtime.util".

> Deduplication of ResourceCounter
> --------------------------------
>
>                 Key: FLINK-21221
>                 URL: https://issues.apache.org/jira/browse/FLINK-21221
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Coordination
>            Reporter: Yangze Guo
>            Priority: Major
>              Labels: starter
>
> Currently, we have two {{ResourceCounter}} in our code base:
> - org.apache.flink.runtime.jobmaster.slotpool.ResourceCounter. Used in 
> SlotPool component.
> - org.apache.flink.runtime.slots.ResourceCounter. Used in SlotManager 
> component.
> Functionally speaking, these two {{ResourceCounter}} are the same. We can 
> merge them to one class for deduplication.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to