rkhachatryan commented on a change in pull request #14814:
URL: https://github.com/apache/flink/pull/14814#discussion_r568848982
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java
##########
@@ -163,9 +163,18 @@ protected void
processInput(MailboxDefaultAction.Controller controller) throws E
.isPresent()) {
mailboxProcessor.reportThrowable(
new
CancelTaskException(sourceThreadThrowable));
- } else if (!isFinished && sourceThreadThrowable !=
null) {
+ } else if (!wasStoppedExternally &&
sourceThreadThrowable != null) {
mailboxProcessor.reportThrowable(sourceThreadThrowable);
+ } else if (sourceThreadThrowable != null
+ || isCanceled()
+ || wasStoppedExternally) {
+ mailboxProcessor.allActionsCompleted();
} else {
+ // this is a "true" end of input regardless of
whether
+ // stop-with-savepoint was issued or not
+ synchronized (lock) {
Review comment:
This can be either task thread or source thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
