tillrohrmann commented on a change in pull request #14804:
URL: https://github.com/apache/flink/pull/14804#discussion_r568807288
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherGateway.java
##########
@@ -73,7 +74,7 @@
* FlinkJobNotFoundException}
*/
@Override
- CompletableFuture<ArchivedExecutionGraph> requestJob(JobID jobId,
@RpcTimeout Time timeout);
+ CompletableFuture<ExecutionGraphInfo> requestJob(JobID jobId, @RpcTimeout
Time timeout);
Review comment:
It might be a bit easier to not change the return type of this method
and instead to introduce a new method `CompletableFuture<ExecutionGraphInfo>
requestJobInfo()`. Then, one could even add a default implementation of this
method to call
`requestJobInfo().thenApply(ExecutionGraphInfo::getArchivedExecutionGraph)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
