JingsongLi commented on a change in pull request #14766:
URL: https://github.com/apache/flink/pull/14766#discussion_r568547335
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveLookupTableSource.java
##########
@@ -323,5 +324,28 @@ public HiveTablePartitionFetcherContext(
}
}
}
+
+ @Override
+ public HiveTablePartition toHiveTablePartition(HiveTablePartition
partition) {
+ return partition;
+ }
+
+ @Override
+ public ObjectPath getTablePath() {
Review comment:
I think we need a `HivePartitionContext` which is used by look up source.
And have a `HiveContinuousPartitionContext` extends `HivePartitionContext`
which is used by continuous source.
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveLookupTableSource.java
##########
@@ -323,5 +324,28 @@ public HiveTablePartitionFetcherContext(
}
}
}
+
+ @Override
+ public HiveTablePartition toHiveTablePartition(HiveTablePartition
partition) {
+ return partition;
+ }
+
+ @Override
+ public ObjectPath getTablePath() {
Review comment:
So here don't need provides ugly methods to lookup source.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
