[
https://issues.apache.org/jira/browse/FLINK-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15210096#comment-15210096
]
ASF GitHub Bot commented on FLINK-3651:
---------------------------------------
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1830#issuecomment-200795802
Good catch! The changes look good to me.
I tried running the adjusted `RollingSinkFaultToleranceITCase` and
`RollingSinkFaultTolerance2ITCase` w/o the fix in `RollingSink` and they still
succeeded.
If this expected? Is there a way we can test this differently?
> Fix faulty RollingSink Restore
> ------------------------------
>
> Key: FLINK-3651
> URL: https://issues.apache.org/jira/browse/FLINK-3651
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
>
> The RollingSink restore logic has a bug where the sink for subtask index 1
> also removes files for subtask index 11 because the regex that checks for the
> file name also matches that one. Adding the suffix to the regex should solve
> the problem because then the regex for 1 will only match files for subtask
> index 1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
