Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1818#issuecomment-200802077
The changes look good and make parts where user code is serialized very
clear. :+1:
I've verified that the `ScalaShellITCase` with the change in this PR fails
for the current master. I'm wondering whether it is possible to make the test
for this more explicit by adding a JAR with the example program outlined in the
JIRA issue to the `ClassLoaderITCase`.
In any case, +1 to merge. It's your call whether you add a further class
loader test or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
