leonardBang commented on a change in pull request #14849:
URL: https://github.com/apache/flink/pull/14849#discussion_r569371819
##########
File path:
flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/UnsignedTypeConversionITCase.java
##########
@@ -106,7 +106,7 @@ public static void prepareMariaDB() throws
IllegalStateException {
if (!initDbSuccess) {
throw new IllegalStateException(
String.format(
- "Initialize MySQL database instance failed after
{} attempts,"
+ "Initialize MySQL database instance failed after
%s attempts,"
Review comment:
nice catch? how about %s -> %d
##########
File path:
flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/UnsignedTypeConversionITCase.java
##########
@@ -95,7 +95,7 @@ public static void prepareMariaDB() throws
IllegalStateException {
}
}
} catch (Exception e) {
- logger.warn("Initialize DB fail caused by {}", e);
+ logger.warn("Initialize DB fail caused by ", e);
Review comment:
this should work properly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
