curcur commented on a change in pull request #14838: URL: https://github.com/apache/flink/pull/14838#discussion_r569963528
########## File path: flink-state-backends/flink-statebackend-changelog/src/test/java/org/apache/flink/changelog/StateChangelogClientTest.java ########## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.changelog; + +import org.apache.flink.changelog.fs.StateChangeFormat; +import org.apache.flink.changelog.inmemory.InMemoryStateChangelogClient; +import org.apache.flink.runtime.jobgraph.OperatorID; +import org.apache.flink.runtime.state.KeyGroupRange; +import org.apache.flink.runtime.state.StateChange; +import org.apache.flink.runtime.state.StateChangelogHandle; +import org.apache.flink.util.CloseableIterator; +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.TemporaryFolder; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.Random; +import java.util.stream.Collectors; +import java.util.stream.Stream; + +import static java.util.function.Function.identity; +import static java.util.stream.Collectors.toMap; +import static java.util.stream.StreamSupport.stream; +import static org.junit.Assert.assertArrayEquals; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; + +/** {@link InMemoryStateChangelogClient} test. */ +@RunWith(Parameterized.class) +public class StateChangelogClientTest { + + private final Random random = new Random(); + private final LogClientType clientType; + + @Parameterized.Parameters(name = "{0}") + public static Object[] parameters() { + return LogClientType.values(); + } + + @Rule public TemporaryFolder temporaryFolder = new TemporaryFolder(); + + public StateChangelogClientTest(LogClientType logClientType) { + this.clientType = logClientType; + } + + @Test(expected = IllegalStateException.class) + public void testNoAppendAfterClose() throws IOException { + StateChangelogWriter<?> writer = + clientType.create(this).createWriter(new OperatorID(), KeyGroupRange.of(0, 0)); + writer.close(); + writer.append(0, new byte[0]); + } + + @Test + public void testWriteAndRead() throws Exception { + KeyGroupRange kgRange = KeyGroupRange.of(0, 5); + Map<Integer, List<byte[]>> appendsByKeyGroup = generateAppends(kgRange, 10, 20); + + try (StateChangelogClient<?> client = clientType.create(this); + StateChangelogWriter<?> writer = client.createWriter(new OperatorID(), kgRange)) { + SequenceNumber from = writer.lastAppendedSqn(); + appendsByKeyGroup.forEach( + (group, appends) -> appends.forEach(bytes -> writer.append(group, bytes))); + + StateChangelogHandle<?> handle = writer.persist(from).get(); + + assertByteMapsEqual(appendsByKeyGroup, extract(handle)); + } + } + + private void assertByteMapsEqual( + Map<Integer, List<byte[]>> expected, Map<Integer, List<byte[]>> actual) { + assertEquals(expected.size(), actual.size()); + for (Map.Entry<Integer, List<byte[]>> e : expected.entrySet()) { + List<byte[]> expectedList = e.getValue(); + List<byte[]> actualList = actual.get(e.getKey()); + Iterator<byte[]> ite = expectedList.iterator(), ale = actualList.iterator(); + while (ite.hasNext() && ale.hasNext()) { + assertArrayEquals(ite.next(), ale.next()); + } + assertFalse(ite.hasNext()); + assertFalse(ale.hasNext()); + } + } + + private Map<Integer, List<byte[]>> extract(StateChangelogHandle<?> handle) throws Exception { + Map<Integer, List<byte[]>> changes = new HashMap<>(); + //noinspection unchecked + StateChangelogHandle<Object> objHandle = (StateChangelogHandle<Object>) handle; + try (CloseableIterator<StateChange> it = objHandle.getChanges(clientType.getContext())) { + while (it.hasNext()) { + StateChange change = it.next(); + changes.computeIfAbsent(change.getKeyGroup(), k -> new ArrayList<>()) + .add(change.getChange()); + } + } + return changes; + } + + private Map<Integer, List<byte[]>> generateAppends( + KeyGroupRange kgRange, int keyLen, int appendsPerGroup) { + return stream(kgRange.spliterator(), false) + .collect(toMap(identity(), unused -> generateData(appendsPerGroup, keyLen))); + } + + private List<byte[]> generateData(int numAppends, int keyLen) { + return Stream.generate(() -> randomBytes(keyLen)) + .limit(numAppends) + .collect(Collectors.toList()); + } + + private byte[] randomBytes(int len) { + byte[] bytes = new byte[len]; + random.nextBytes(bytes); + return bytes; + } + + private enum LogClientType { + MEMORY { + @Override + public StateChangelogClient<?> create(StateChangelogClientTest logClientTest) { + return new InMemoryStateChangelogClient(); + } + + @Override + public StateChangeFormat getContext() { Review comment: "StateChangeFormat" is missing? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
