zentol commented on a change in pull request #14790:
URL: https://github.com/apache/flink/pull/14790#discussion_r570102668
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java
##########
@@ -151,6 +153,19 @@ protected ClusterEntrypoint(Configuration configuration) {
this.configuration = generateClusterConfiguration(configuration);
this.terminationFuture = new CompletableFuture<>();
+ if (configuration.get(JobManagerOptions.SCHEDULER_EXECUTION_MODE)
+ == SchedulerExecutionMode.REACTIVE
+ && !this.getClass()
+ .getSimpleName()
+ .equals("StandaloneApplicationClusterEntryPoint")) {
Review comment:
let's add `protected boolean supportsReactiveMode() { return false; }`
and override it in the `StandaloneApplicationClusterEntryPoint`
adjust the test accordingly to use a test entrypoint implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
