rkhachatryan commented on a change in pull request #14740:
URL: https://github.com/apache/flink/pull/14740#discussion_r570818510
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -2132,23 +2123,41 @@ public boolean isForce() {
}
private void reportToStatsTracker(
- PendingCheckpoint checkpoint, Map<ExecutionAttemptID,
ExecutionVertex> tasks) {
+ PendingCheckpoint checkpoint,
+ Map<ExecutionAttemptID, ExecutionVertex> tasks,
+ List<Execution> finishedTasks) {
if (statsTracker == null) {
return;
}
Map<JobVertexID, Integer> vertices =
- tasks.values().stream()
+ Stream.concat(
+ tasks.values().stream(),
+
finishedTasks.stream().map(Execution::getVertex))
.map(ExecutionVertex::getJobVertex)
.distinct()
.collect(
toMap(
ExecutionJobVertex::getJobVertexId,
ExecutionJobVertex::getParallelism));
- checkpoint.setStatsCallback(
+
+ PendingCheckpointStats pendingCheckpointStats =
statsTracker.reportPendingCheckpoint(
checkpoint.getCheckpointID(),
checkpoint.getCheckpointTimestamp(),
checkpoint.getProps(),
- vertices));
+ vertices);
+ checkpoint.setStatsCallback(pendingCheckpointStats);
+
+ reportFinishedTasks(pendingCheckpointStats, finishedTasks);
+ }
+
+ private void reportFinishedTasks(
+ PendingCheckpointStats pendingCheckpointStats, List<Execution>
finishedTasks) {
+ long now = System.currentTimeMillis();
+ finishedTasks.forEach(
+ execution ->
+ pendingCheckpointStats.reportSubtaskStats(
Review comment:
Highlighting finished subtasks can be helpful, but I agree it can be
done later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
