XComp edited a comment on pull request #14798: URL: https://github.com/apache/flink/pull/14798#issuecomment-774663350
There seems to be some test instability in the fine-grained source data now with the invariant being added. The [Azure build attached to this PR](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=13005&view=logs&j=a57e0635-3fad-5b08-57c7-a4142d7d6fa9&t=5360d54c-8d94-5d85-304e-a89267eb785a) succeeded. [Another Azure build on the same commit](https://dev.azure.com/mapohl/flink/_build/results?buildId=221&view=logs&j=cc649950-03e9-5fae-8326-2f1ad744b536&t=51cab6ca-669f-5dc0-221d-1e4f7dc4fc85&l=5837) failed in `TaskExecutorSlotLifetimeTest`. The test failure is caused by the newly introduced Precondition. To me, that looks like an issue in the fine-grained resource management code or some other parts of the code which we should investigate. I'd prefer to create a Jira issue covering this instead of relaxing the state change conditions again and work around it in the exception history. I still think that the invariant makes sense and we shouldn't relax it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
