zentol commented on a change in pull request #14790: URL: https://github.com/apache/flink/pull/14790#discussion_r571941281
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/entrypoint/ClusterEntrypointTest.java ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.entrypoint; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.IllegalConfigurationException; +import org.apache.flink.configuration.JobManagerOptions; +import org.apache.flink.configuration.SchedulerExecutionMode; +import org.apache.flink.runtime.concurrent.ScheduledExecutor; +import org.apache.flink.runtime.dispatcher.ArchivedExecutionGraphStore; +import org.apache.flink.runtime.entrypoint.component.DispatcherResourceManagerComponentFactory; + +import org.junit.Test; + +import java.io.IOException; + +import static org.junit.Assert.fail; + +/** Tests for the {@link ClusterEntrypoint}. */ +public class ClusterEntrypointTest { + + @Test(expected = IllegalConfigurationException.class) + public void testStandaloneSessionClusterEntrypointDeniedInReactiveMode() { + Configuration configuration = new Configuration(); + configuration.set(JobManagerOptions.SCHEDULER_MODE, SchedulerExecutionMode.REACTIVE); + new MockEntryPoint(configuration); + fail("Entrypoint initialization is supposed to fail"); + } + + private static class MockEntryPoint extends ClusterEntrypoint { Review comment: maybe explicitly override the new method to return false, in case we invert the default behavior at some point. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
