tillrohrmann commented on a change in pull request #14874:
URL: https://github.com/apache/flink/pull/14874#discussion_r572201368
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
##########
@@ -358,6 +358,17 @@
.list(text("'ng': new generation
scheduler"))
.build());
+ @Documentation.Section({
+ Documentation.Sections.EXPERT_SCHEDULING,
+ Documentation.Sections.ALL_JOB_MANAGER
+ })
+ public static final ConfigOption<Integer> MIN_PARALLELISM_INCREASE =
+ key("jobmanager.declarative-scheduler.min-parallelism-increase")
+ .intType()
+ .defaultValue(1)
+ .withDescription(
+ "Configure the minimum increase in parallelism for
a job to scale up.");
Review comment:
I would expect that CI won't pass because the configuration
documentation has not been updated.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/declarative/scalingpolicy/ReactiveScaleUpController.java
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.scheduler.declarative.scalingpolicy;
+
+import org.apache.flink.configuration.Configuration;
+
+import static
org.apache.flink.configuration.JobManagerOptions.MIN_PARALLELISM_INCREASE;
+
+/**
+ * Simple scaling policy for a reactive mode. The user can configure a minimum
cumulative
+ * parallelism increase to allow a scale up.
+ */
+public class ReactiveScaleUpController implements ScaleUpController {
+
+ private final int minParallelismIncrease;
+
+ public ReactiveScaleUpController(Configuration configuration) {
+ minParallelismIncrease = configuration.get(MIN_PARALLELISM_INCREASE);
Review comment:
we don't have to change it right now but if things become more complex I
would suggest to separate the `ReactiveScaleUpController` and how it is set up
from a `Configuration`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
