KarmaGYZ commented on a change in pull request #14897:
URL: https://github.com/apache/flink/pull/14897#discussion_r572517152
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/util/ResourceCounter.java
##########
@@ -35,11 +37,12 @@
* associated counts. The counts are always positive (> 0).
*/
public final class ResourceCounter {
Review comment:
Each time we add a `ResourceProfile` to it, all the `ResourceProfile`s
recorded will be put into a new map, with O(nlogn) complexity. For
coarse-grained resource management, that's might be ok since we only have one
type of requirement and one type of slot(for standalone mode, that assumption
might be broken). However, for fine-grained resource management, performance
can get bad.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
