[
https://issues.apache.org/jira/browse/FLINK-21323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17281568#comment-17281568
]
Kezhu Wang commented on FLINK-21323:
------------------------------------
[~mapohl] [~roman_khachatryan] [~pnowojski] Maybe we can provide a fix solely
for {{SourceOperatorStreamTask}} but not chained out FLIP-27 source ? This way
we can deliver it to 1.12.2 on time. I could open a fix for this if this make
sense.
> Stop-with-savepoint is not supported by SourceOperatorStreamTask
> ----------------------------------------------------------------
>
> Key: FLINK-21323
> URL: https://issues.apache.org/jira/browse/FLINK-21323
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Common
> Affects Versions: 1.11.3, 1.12.1
> Reporter: Matthias
> Priority: Critical
> Fix For: 1.11.4, 1.12.2, 1.13.0
>
>
> When looking into FLINK-21030 analyzing the stop-with-savepoint behavior we
> implemented different test jobs covering the old {{addSource}} and new
> {{fromSource}} methods for adding sources. The stop-with-savepoint consists
> of two phase:
> # Create the savepoint
> # Stop the source to trigger finalizing the job
> The test failing in the second phase using {{fromSource}} does not succeed.
> The reason for this might be that {{finishTask}} is not implemented by
> {{SourceOperatorStreamTask}} in contrast to {{SourceStreamTask}} which is
> used when calling {{addSource}} in the job definition. Hence, the job
> termination is never triggered.
> We might have missed this due to some naming error of
> {{JobMasterStopWithSavepointIT}} test that is not triggered by Maven due to
> the wrong suffix used in this case. The IT is failing right now. FLINK-21031
> is covering the fix of {{JobMasterStopWithSavepointIT}} already.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
