rmetzger commented on a change in pull request #14879:
URL: https://github.com/apache/flink/pull/14879#discussion_r573722998
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/declarative/ExecutingTest.java
##########
@@ -155,11 +155,53 @@ public void
testTransitionToFinishedOnFailedExecutionGraph() throws Exception {
}
}
+ @Test
+ public void testEnsureOnlyGlobalTerminalStateCallbacksNoCall() throws
Exception {
+ // modify MockExecutingContext to disable the "runIfState()" check
+ MockExecutingContext ctx =
+ new MockExecutingContext() {
+ @Override
+ public void runIfState(State expectedState, Runnable
action) {
+ action.run();
+ }
+ };
Review comment:
If you got a hammer, everything is a nail. I agree that the tests are
misplaced here. I'll remove them from this PR and introduce them through a new
ticket: https://issues.apache.org/jira/browse/FLINK-21348
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
