LadyForest commented on a change in pull request #14938:
URL: https://github.com/apache/flink/pull/14938#discussion_r575826777
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/config/entries/ModuleEntry.java
##########
@@ -61,6 +62,15 @@ private static ModuleEntry create(DescriptorProperties
properties) {
final DescriptorProperties cleanedProperties =
properties.withoutKeys(Collections.singletonList(MODULE_NAME));
+ // mapping modules purely by name
+ if (cleanedProperties.containsKey(MODULE_TYPE)) {
+ throw new ValidationException(
Review comment:
Hi Jark, it seems the summary conclusion missed this part and directly
updated the YAML format.
I'll update Jira and make type an optional key in the YAML file to keep
backward-compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
