[
https://issues.apache.org/jira/browse/FLINK-21365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17284606#comment-17284606
]
Piotr Nowojski commented on FLINK-21365:
----------------------------------------
I think this issue is invalid and it actually works as expected, since
`numCompleted#incrementAndGet` establishes happens before between
`results[index] = value;` writes from other threads and the final thread doing
`Arrays.asList(results)` AFAI-can-tell.
Not that it's not confusing and at the very least should be documented. Also I
guess it makes the `volatile` definition of the array unnecessary?
> Visibility issue in FutureUtils.ResultConjunctFuture.handleCompletedFuture
> ---------------------------------------------------------------------------
>
> Key: FLINK-21365
> URL: https://issues.apache.org/jira/browse/FLINK-21365
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Coordination
> Affects Versions: 1.11.3, 1.12.1
> Reporter: Roman Khachatryan
> Assignee: Roman Khachatryan
> Priority: Major
> Fix For: 1.11.4, 1.12.2, 1.13.0
>
>
> * FutureUtils.ResultConjunctFuture.handleCompletedFuture can update *results*
> array from multiple threads
> * The array is declared as volatile but this only means the reference is
> volatile, not the contents
> * There are no other guards
--
This message was sent by Atlassian Jira
(v8.3.4#803005)