rkhachatryan commented on a change in pull request #14838: URL: https://github.com/apache/flink/pull/14838#discussion_r577873641
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/StateChangelogWriterFactoryLoader.java ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.state.changelog; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.core.plugin.PluginManager; + +import java.util.Iterator; + +/** A thin wrapper around {@link PluginManager} to load {@link StateChangelogWriterFactory}. */ +@Internal +public class StateChangelogWriterFactoryLoader { + private final PluginManager pluginManager; + + public StateChangelogWriterFactoryLoader(PluginManager pluginManager) { + this.pluginManager = pluginManager; + } + + @SuppressWarnings({"rawtypes"}) + public Iterator<StateChangelogWriterFactory> load() { + return pluginManager.load(StateChangelogWriterFactory.class); + } +} Review comment: It should suggest users to rely on SPI/plugins instead of direct instantiation. SPI part was missing which I guess confused you, sorry for that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
