XComp commented on a change in pull request #14798:
URL: https://github.com/apache/flink/pull/14798#discussion_r579259796
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java
##########
@@ -635,6 +641,33 @@ public void cancel() {
return
executionGraph.getTerminationFuture().thenApply(FunctionUtils.nullFn());
}
+ protected void archiveGlobalFailure(Throwable failure) {
+ taskFailureHistory.add(
+ new ErrorInfo(failure,
executionGraph.getStatusTimestamp(JobStatus.FAILED)));
+ log.debug("Archive global failure.", failure);
+ }
+
+ protected void archiveFromFailureHandlingResult(FailureHandlingResult
failureHandlingResult) {
+ Optional<Execution> executionOptional =
+ failureHandlingResult
+ .getExecutionVertexIdOfFailedTask()
+ .map(this::getExecutionVertex)
+ .map(ExecutionVertex::getCurrentExecutionAttempt);
+
+ executionOptional.ifPresent(
+ execution ->
+ execution
+ .getFailureInfo()
+ .ifPresent(
+ failureInfo -> {
+
taskFailureHistory.add(failureInfo);
+ log.debug(
+ "Archive local failure
causing attempt {} to fail: {}",
+ execution.getAttemptId(),
+
failureInfo.getExceptionAsString());
+ }));
Review comment:
Yes, that would be possible if would would like to relax the constraint
that the exception history does not provide the timestamp the `Execution` was
marked as failed but an earlier timestamp. But to be fair, we do that already
for the fallback of a global failover in `archiveFromFailureHandlingResult`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
