PatrickRen commented on pull request #14789: URL: https://github.com/apache/flink/pull/14789#issuecomment-782547796
@becketqin Thank you~ I changed my implementation and made another commit. Now ```NoMoreSplitsEvent``` will be sent in ```addReader()``` so all readers will be notified and we don't need to "remember" readers that have been signaled. There is possibility that ```addReader()``` could be invoked before the first partition discovery and split assignment, so I add a set called ```finishingReaders``` for tracking these early-added readers, and signal ```MoMoreSplitsEvent``` to them later after the first discovery and assignment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
