tillrohrmann commented on a change in pull request #14804:
URL: https://github.com/apache/flink/pull/14804#discussion_r580494990
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobManagerRunnerResult.java
##########
@@ -81,21 +83,23 @@ public boolean equals(Object o) {
return false;
}
JobManagerRunnerResult that = (JobManagerRunnerResult) o;
- return Objects.equals(archivedExecutionGraph,
that.archivedExecutionGraph)
+ // TODO: verify ExecutionGraphInfo.equals
Review comment:
I think `JobManagerRunnerResult` should not have an `equals` and
`hashCode` method. Usually only objects which you want to compare or use in a
`HashMap` should implement these methods. We sometimes added these methods
because we did not write a `Matcher` when using it in tests. However, this was
more because of laziness than good software engineering. The problem is that if
this is only used in tests, then it should probably be a test concern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
