wangyang0918 commented on a change in pull request #14891:
URL: https://github.com/apache/flink/pull/14891#discussion_r580750152
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/deployment/application/ClassPathPackagedProgramRetriever.java
##########
@@ -276,9 +299,21 @@ public Builder setJarFile(File file) {
return this;
}
+ public Builder setConfiguration(Configuration configuration) {
+ this.configuration = configuration;
+ return this;
+ }
+
public ClassPathPackagedProgramRetriever build() throws IOException {
- return new ClassPathPackagedProgramRetriever(
- programArguments, jobClassName, jarsOnClassPath,
userLibDirectory, jarFile);
+ ClassPathPackagedProgramRetriever
classPathPackagedProgramRetriever =
Review comment:
Local variable `classPathPackagedProgramRetriever` is redundant.
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/entrypoint/KubernetesApplicationClusterEntrypoint.java
##########
@@ -111,7 +111,8 @@ private static PackagedProgramRetriever
getPackagedProgramRetriever(
final ClassPathPackagedProgramRetriever.Builder retrieverBuilder =
ClassPathPackagedProgramRetriever.newBuilder(programArguments)
.setUserLibDirectory(userLibDir)
- .setJobClassName(jobClassName);
+ .setJobClassName(jobClassName)
+ .setConfiguration(configuration);
Review comment:
We also need to `setConfiguration` for
`StandaloneApplicationClusterEntryPoint`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
