PChou commented on a change in pull request #14891:
URL: https://github.com/apache/flink/pull/14891#discussion_r580771925



##########
File path: 
flink-clients/src/main/java/org/apache/flink/client/deployment/application/ClassPathPackagedProgramRetriever.java
##########
@@ -276,9 +299,21 @@ public Builder setJarFile(File file) {
             return this;
         }
 
+        public Builder setConfiguration(Configuration configuration) {
+            this.configuration = configuration;
+            return this;
+        }
+
         public ClassPathPackagedProgramRetriever build() throws IOException {
-            return new ClassPathPackagedProgramRetriever(
-                    programArguments, jobClassName, jarsOnClassPath, 
userLibDirectory, jarFile);
+            ClassPathPackagedProgramRetriever 
classPathPackagedProgramRetriever =

Review comment:
       OK. i am going to fix it and add some test




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to