dawidwys commented on a change in pull request #14913:
URL: https://github.com/apache/flink/pull/14913#discussion_r581931797
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
##########
@@ -290,6 +294,16 @@ public RocksDBKeyedStateBackend(
this.nativeMetricMonitor = nativeMetricMonitor;
this.sharedRocksKeyBuilder = sharedRocksKeyBuilder;
this.priorityQueueFactory = priorityQueueFactory;
+ if (priorityQueueFactory instanceof HeapPriorityQueueSetFactory) {
Review comment:
What kind of method would you see instead? The priorityQueueManager can
be constructed only for the `HeapPriorityQueueSetFactory` therefore it is not a
general purpose method of the interface.
Moreover the problem right now is that `CheckpointableKeyedStateBackend`
extends from `PriorityQueueSetFactory`. I am afraid no method would fit there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
