bytesandwich opened a new pull request #15017:
URL: https://github.com/apache/flink/pull/15017
## What is the purpose of the change
Add max parallelism for reporting purposes to the REST api.
## Brief change log
Add max-parallelism to:
- JobVertexDetailsHandler puts maxaParallelism into JobVertexDetailsInfo
from jobVertex
- JobDetailsHandler pus:
- maxParallelism into JobDetailsInfo from ExecutionGraph's archived
execution config
- maxParallelism into JobVertexDetailsInfo from AccessExecutionJobVertex
- ArchivedExecutionConfig
- JobDetailsInfo as "job-max-parallelism"
- JobDetailsInfo.JobVertexDetailsInfo as "max-parallelism"
- JobVertexDetailsInfo as "max-parallelism"
All have max parallelism added to equals and hash (except
ArchivedExecutionConfig)
Resets ArchivedExecutionConfig's `serialVersionUID`
also adds to angular type definitions.
*(For example: This pull request makes task deployment go through the blob
server, rather than through RPC. That way we avoid re-transferring them on each
deployment (during recovery).)*
## Verifying this change
This change is already covered by existing tests, such as
`JobDetailsInfoTest` and `JobVertexDetailsInfoTest`. As I'm developing on
windows linux subsystem, my maven build works but I am unable to run tests
locally. Is there an automation that runs them to check this PR?
I did manually run the REST api against a local cluster from the
bin/start-cluster.sh of TopSpeedWindowing example with
`env.getConfig().setMaxParallelism(4)` and `.setMaxParallelism(2);` on an
operator
In both `/jobs`and `/jobs/:id` I saw that "job-max-parallelism" was set to 4
and "max-parallelism" was set to "2" for the specific vertex and "4" for others.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no but I feel like it should?
- The serializers: yes the ArchivedExecutionConfig's java serializability
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? slightly
- If yes, how is the feature documented? Needs a follow up for the REST
api docs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
