wangyang0918 commented on pull request #14629: URL: https://github.com/apache/flink/pull/14629#issuecomment-785978493
@tillrohrmann Thanks for your comments and suggestions. I have updated this PR. The main changes are list as followings. * Add a separate decorator for `PodTemplateMountDecorator` which is only used for `KubernetesJobManagerFactory`. And then we could still keep the file existence check. * Introduce new mechanism for resolving effective field values. "Defined by Flink", "Defined by the user" and "Merged with Flink". The documentation is updated accordingly. For your posted two problems, the first one is a bug and has been fixed. For the second one, I think it is an expected behavior. We have deferred the sanity check to the Fabric8 Kubernetes client, which will call the Kubernetes APIServer for the verification. I admin that the exception is not friendly, but you still could find the root cause `spec.template.spec.containers[0].image: Required value`. I guess you do not set the image for the non-main container. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
