lirui-apache commented on a change in pull request #14841: URL: https://github.com/apache/flink/pull/14841#discussion_r583616554
########## File path: flink-yarn/src/main/java/org/apache/flink/yarn/security/HadoopDelegationTokenProvider.java ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.yarn.security; Review comment: But if we put the interface in `flink-yarn` module, it's not possible for other deployments to implement this interface, unless they depend on `flink-yarn` right? So perhaps it's better to put it in `flink-runtime`? ########## File path: flink-yarn/src/main/java/org/apache/flink/yarn/security/HadoopDelegationTokenProvider.java ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.yarn.security; + +import org.apache.flink.configuration.Configuration; + +import org.apache.hadoop.security.Credentials; + +import java.util.Optional; + +/** Hadoop delegation token provider. */ +public interface HadoopDelegationTokenProvider { + + /** Name of the service to provide delegation tokens. This name should be unique. */ + String serviceName(); + + /** + * Return true if delegation tokens are required for this service. + * + * @param flinkConf Flink configuration + * @param hadoopConf Hadoop configuration + * @return true if delegation tokens are required + */ + boolean delegationTokensRequired( Review comment: I mean it's not clear whether `delegationTokensRequired` and `obtainDelegationTokens` get the same configurations. And what `obtainDelegationTokens` should do if DT is not required at all. We need to clarify these in the API contract. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
