igalshilman commented on a change in pull request #203:
URL: https://github.com/apache/flink-statefun/pull/203#discussion_r583656064
##########
File path:
statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/message/MessagePayloadSerializerKryo.java
##########
@@ -40,8 +41,7 @@ public Payload serialize(@Nonnull Object payloadObject) {
} catch (IOException e) {
throw new IllegalStateException(e);
}
- // TODO: avoid copying, consider adding a zero-copy ByteString.
- ByteString serializedBytes = ByteString.copyFrom(target.getSharedBuffer(),
0, target.length());
+ ByteString serializedBytes =
MoreByteStrings.wrap(target.getSharedBuffer(), 0, target.length());
Review comment:
@tzulitai - just a reminder: please undo this change before you merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
