tillrohrmann commented on a change in pull request #15031:
URL: https://github.com/apache/flink/pull/15031#discussion_r583714633



##########
File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/JobLeaderIdServiceTest.java
##########
@@ -274,4 +277,56 @@ public Object answer(InvocationOnMock invocation) throws 
Throwable {
         // the new timeout should be valid
         assertTrue(jobLeaderIdService.isValidTimeout(jobId, 
lastTimeoutId.get()));
     }
+
+    /**
+     * Tests that a timeout get cancelled once a job leader has been found. 
Furthermore, it tests

Review comment:
       Where do we test the aspect of the timeout?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to